[SYCL] Rework of SYCL poperties #2196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed property_list class to support properties of unknown type. This is achieved by splitting properties to two types: simple and complex. Simple are those which do not have any date - just represent that something is enabled or disabled. Compilex properties have some data. Simple properties have compile time known id, so they are always stored in the property_list even if they are not set. Complex are allocated dynamically and accessed through the common base class.
keryell
reviewed
Jul 29, 2020
v-klochkov
reviewed
Jul 29, 2020
…ListImprovements_PropList
v-klochkov
approved these changes
Jul 30, 2020
jsji
pushed a commit
that referenced
this pull request
Nov 9, 2023
This commit adds StridesizeINTEL, WordsizeINTEL and TrueDualPortINTEL support to translator. Original commit: KhronosGroup/SPIRV-LLVM-Translator@5c1e2c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed property_list class to support properties of unknown
type. This is achieved by splitting properties to two types:
simple and complex. Simple are those which do not have any
date - just represent that something is enabled or disabled.
Compilex properties have some data.
Simple properties have compile time known id, so they are
always stored in the property_list even if they are not set.
Complex are allocated dynamically and accessed through the
common base class.