[SYCL] Fix specialization constants struct members #2232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FE crashed on attempt to create initializer for struct with spec constant members because there was no initializers for spec const fields. Added default initialization for spec constants.
Fznamznon
requested review from
elizabethandrews,
premanandrao and
a team
as code owners
|
/summary:run |
s-kanaev
reviewed
Jul 31, 2020
premanandrao
previously approved these changes
Aug 3, 2020
premanandrao
approved these changes
Aug 3, 2020
s-kanaev
approved these changes
Aug 4, 2020
|
@Fznamznon Sorry, I've missed the notification somehow. |
kbobrovs
approved these changes
Aug 4, 2020
jsji
pushed a commit
that referenced
this pull request
Nov 30, 2023
…ter (#2232) This fixes reverse translation for SPV_INTEL_fpga_memory_accesses. Theoretically it fixes more, but seems like without the extension we don't generate UserSemantic decoration in this case at all. Will be investigated separately. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@ef0165a
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FE crashed on attempt to create initializer for struct with spec
constant members because there was no initializers for spec const
fields. Added default initialization for spec constants.