[SYCL][FPGA] Minor fix to the fpga_lsu header #2233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, closing for now. This may not be an actual problem. |
|
These look like actual problems... |
The changes in the doc need to be fixed for sure. |
mohammadfawaz
force-pushed
the
lsu_builtins_fix
branch
from
3f66098 to
e698175
Compare
|
@mohammadfawaz, could you resolve merge conflict, please? |
mohammadfawaz
force-pushed
the
lsu_builtins_fix
branch
from
e698175 to
33636e9
Compare
The load function should not return a ref. The translator expects the pointer annotation result to be loaded directly. Also, small minor fixes to the spec
mohammadfawaz
force-pushed
the
lsu_builtins_fix
branch
from
33636e9 to
5b2e1eb
Compare
|
@intel/dpcpp-specification-reviewers, @intel/llvm-reviewers-runtime, ping. |
alexbatashev
approved these changes
Aug 19, 2020
|
@mlychkov Could you please, review? |
mlychkov
approved these changes
Aug 19, 2020
jbrodman
approved these changes
Aug 20, 2020
jsji
pushed a commit
that referenced
this pull request
Dec 21, 2023
) Pointer named Expected was taken by reference to closure to be executed later by Mutator. Mutator executes the closure in his destructor which happens after the destruction of Expected pointer stack frame. This fix clears some ASan errors from #2233. Original commit: KhronosGroup/SPIRV-LLVM-Translator@c7cd904
jsji
pushed a commit
that referenced
this pull request
Dec 21, 2023
Allocated SPIRVExecutionMode class wasn't added as dependant resource in SPIRVModule. Fix some ASan errors in issue #2233. Original commit: KhronosGroup/SPIRV-LLVM-Translator@1a19f6f
jsji
pushed a commit
that referenced
this pull request
Jan 4, 2024
…2265) ImageOpMask pointer was passed to closure as reference. Closure is executed outside of original stack frame which renders reference invalid. Fixes some ASan errors from issue #2233. Original commit: KhronosGroup/SPIRV-LLVM-Translator@29d4cd3
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Improvements to align CTS and Spec for Memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The load function should not return a ref. The translator expects the pointer
annotation result to be loaded directly.
Also, small minor fixes to the spec