[SYCL] Fix memory leak for sycl::device::get_devices #2256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins create pi_device objects for root devices, but it does not call piDeviceRelease and causes memory leaks. This slows the performance of SYCL apps. Signed-off-by: Byoungro So <byoungro.so@intel.com>
|
@bader @vladimirlaz @romanovvlad |
romanovvlad
reviewed
Aug 5, 2020
| // | ||
| // UNSUPPORTED: windows | ||
| // | ||
| //==-----memory-consumption.cpp - SYCL memory consumption basic test ------==// |
There was a problem hiding this comment.
I think this test is valuable to check overall memory consumption. But I suggest adding more specific test on the change you are doing, such a verification could be done by setting SYCL_PI_TRACE and checking its output(see sycl/test/scheduler/ReleaseResourcesTest.cpp as an example).
There was a problem hiding this comment.
I will make a follow-up patch for this SYCL_PI_TRACE later.
There was a problem hiding this comment.
I'm OK if additional test will be added in the follow up patch.
romanovvlad
approved these changes
Aug 5, 2020
jsji
pushed a commit
that referenced
this pull request
Dec 21, 2023
#2256) This patch introduces a way to use runtime values for structure fields. Co-authored-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@a6f017a
jsji
pushed a commit
that referenced
this pull request
Jan 11, 2024
…t pt.2 (#2296) This patch introduces a way to use runtime values for array and vector types. It continues #2256 Original commit: KhronosGroup/SPIRV-LLVM-Translator@4db768c
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Avoid potential ambiguity in UrReturnHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins create pi_device objects for root devices, but
it does not call piDeviceRelease and causes memory leaks.
This slows the performance of SYCL apps.
Signed-off-by: Byoungro So byoungro.so@intel.com