[SYCL][CUDA] Default block size attempts to maximize occupancy #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not seen any performance improvements on BabelStream with this, but I have a very old NVDIA GPU on my desktop, Maybe @jeffhammond can run it in some other configs and see if its any better than the default? EDIT: Got the wrong intel person initially :-) |
jbrodman
approved these changes
Nov 3, 2020
romanovvlad
approved these changes
Nov 6, 2020
jsji
pushed a commit
that referenced
this pull request
Oct 10, 2024
Avoid deprecation warnings after LLVM commit 2f50b28 ("[DebugInfo] Enable deprecation of iterator-insertion methods (#102608)", 2024-09-20). Original commit: KhronosGroup/SPIRV-LLVM-Translator@374eb9d8a4ee0ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
cuOccupancyMaxPotentialBlockSizefunction from the CUDA driver, this patch tries to find a better block size for the default configuration. It takes into account the kernel properties and the dynamic local memory size required by the kernel.