Skip to content

Conversation

@yinyangsx
Copy link

Signed-off-by: yinyangsx yin.yang@intel.com

Signed-off-by: yinyangsx <yin.yang@intel.com>
@yinyangsx
Copy link
Author

/summary:run

vladimirlaz
vladimirlaz previously approved these changes Nov 9, 2020
Copy link
Contributor

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But still need to wait until all test passed

@bader bader changed the title Uplift Win GPU driver version to 27.20.100.8935 [BuildBot] Uplift Win GPU driver version to 27.20.100.8935 Nov 9, 2020
@yinyangsx
Copy link
Author

Hi @yanfeng3721 , a new regression happen on Windows GPU CTS test, could you please have a look?
http://icl-jenkins.sc.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FWin%2FCTS_GPU/detail/CTS_GPU/1701/pipeline

@yanfeng3721
Copy link
Contributor

/summary:run

@yanfeng3721
Copy link
Contributor

yanfeng3721 commented Nov 10, 2020

@yinyangsx @DoyleLi , the regression looks like a flaky issue and I will trigger a rerun.
image

@vladimirlaz
Copy link
Contributor

vladimirlaz commented Nov 10, 2020

@yanfeng3721, @yinyangsx It looks like the flaky issue introduced by new driver. Please file a ticket.

@yanfeng3721
Copy link
Contributor

/summary:run

@yanfeng3721
Copy link
Contributor

@yinyangsx , I checked the post commit test, the Windows test pass, please prepare Windows test driver 27.20.100.8935 update.

@vladimirlaz vladimirlaz merged commit 2354002 into intel:sycl Nov 11, 2020
jsji pushed a commit that referenced this pull request Oct 11, 2024
)

The LLVM-IR type of zero-length array does not seem to have a mapping into SPIR-V type, rather it outputs an error since the obvious choice of zero-length array is not valid in SPIR-V. This, for example, prohibits us from using unbounded arrays in SYCL device kernels because they are typically represented in LLVM-IR through zero-length arrays. This PR attempts to introduce a workaround to this by lowering a zero-length array in LLVM-IR to a 1-length array in SPIR-V.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@38db490f855499c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants