[SYCL][NFC] Remove deprecated variables from LIT #2794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove use of deprecated environment variables (SYCL_BE, SYCL_DEVICE_TYPE) from LIT framework. Use SYCL_DEVICE_FILTER instead: - update [CPU|GPU|ACC]_RUN_PLACEHOLDER to use SYCL_DEVICE_FILTER; - change values format used to define a backend and a device type to match SYCL_DEVICE_FILTER requirements; - add BE_RUN_PLACEHOLDER to set backend only for tests which require that; - add HOST_RUN_PLACEHOLDER to align configuration with other devices; - on-device/basic_tests/diagnostics/device-check.cpp is not changed because it checks SYCL_DEVICE_FILTER itself and will be removed once the variable is removed.
bader
reviewed
Nov 19, 2020
|
LGTM. Thanks. |
|
@rbegam, could you please have a look? |
jsji
pushed a commit
that referenced
this pull request
Nov 7, 2024
#1174 implements translating integer dot product OCL builtins to SPIR-V builtins. This pull request is to do the reverse translation. Original commit: KhronosGroup/SPIRV-LLVM-Translator@925255cb1982896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of deprecated environment variables (SYCL_BE,
SYCL_DEVICE_TYPE) from LIT framework. Use SYCL_DEVICE_FILTER instead:
deprecated environment variable;
match SYCL_DEVICE_FILTER requirements;
that;
command.