Skip to content

[SYCL][CUDA][NFC] Check alignment of USM allocations #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 3, 2020
Merged

[SYCL][CUDA][NFC] Check alignment of USM allocations #2831

merged 4 commits into from
Dec 3, 2020

Conversation

bader
Copy link
Contributor

@bader bader commented Nov 28, 2020

No description provided.

@bader bader requested a review from jbrodman November 28, 2020 10:27
@bader bader requested a review from a team as a code owner November 28, 2020 10:27
@bader bader requested a review from smaslov-intel November 28, 2020 10:27
@bader bader mentioned this pull request Nov 28, 2020
Merged
smaslov-intel
smaslov-intel previously approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why don't you do the same check for other plugins?

@bader
Copy link
Contributor Author

bader commented Nov 30, 2020

This patch intended to address this particular comment: #2557 (comment).

LGTM, but why don't you do the same check for other plugins?

Probably it would be better add validation of piext* results in sycl/source/detail/usm/usm_impl.cpp - the check implementation is not specific to PI implementation.

@smaslov-intel
Copy link
Contributor

This patch intended to address this particular comment: #2557 (comment).

LGTM, but why don't you do the same check for other plugins?

Probably it would be better add validation of piext* results in sycl/source/detail/usm/usm_impl.cpp - the check implementation is not specific to PI implementation.

Actually, I think plugins should better themselves verify their output (similar how they tend to verify inputs).

@bader
Copy link
Contributor Author

bader commented Dec 3, 2020

@smaslov-intel, ping.

@bader bader merged commit 012078c into intel:sycl Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaslov-intel smaslov-intel smaslov-intel approved these changes

@jbrodman jbrodman Awaiting requested review from jbrodman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bader @smaslov-intel