[NFC][SYCL] Run device-agnostic tests separately #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests which do not require backend were run for every target backend. It is waste of machine time. This PR: - move device-agnostic tests to separate target to run only once; - moved all device-specific LIT substitutions to on-device folder to avoid adding device-dependent tests to directory with device-agnostic tests; - move device-dependent tests to sycl/test/on-device folder.
Contributor
sergey-semenov
left a comment
sergey-semenov
left a comment
There was a problem hiding this comment.
Looks good to me aside from a minor comment
sergey-semenov
approved these changes
Dec 22, 2020
bader
reviewed
Dec 23, 2020
| if(SYCL_BUILD_PI_CUDA) | ||
| add_lit_testsuite(check-sycl-cuda "Running the SYCL regression tests for CUDA" | ||
| ${CMAKE_CURRENT_BINARY_DIR} | ||
| ${CMAKE_CURRENT_BINARY_DIR}/on-device |
Contributor
There was a problem hiding this comment.
Please, move "on-device" tests logic to on-device/CMakeLists.txt.
iclsrc
pushed a commit
that referenced
this pull request
Dec 15, 2024
KornevNikita
pushed a commit
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests which do not require backend were run for every target backend. It
is waste of machine time. This PR:
avoid adding device-dependent tests to directory with
device-agnostic tests;