Skip to content

[SYCL][L0] Implement Plugin Lifetime Management #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romanovvlad merged 29 commits into from
Dec 30, 2020
Merged

[SYCL][L0] Implement Plugin Lifetime Management #2942

romanovvlad merged 29 commits into from
Dec 30, 2020

Conversation

@bso-intel
Copy link
Contributor

@bso-intel bso-intel commented Dec 23, 2020

This PR implements the Sycl Lifetime management.
It allows Sycl RT to init / deinit plguins many times.
It also provide opportunity to manage global variables used in plugin PIs.

Signed-off-by: Byoungro So byoungro.so@intel.com

@bso-intel
[SYCL][L0] Implement Plugin Lifetime Management
88354e0 
This PR implements the Sycl Lifetime management.
It allows Sycl RT to init / deinit plguins many times.
It also provide opportunity to manage global variables used in plugin PIs.

Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
Fixed errors
3db0a7b 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
Fix windows casting error
50fb112 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
uplift minor ABI version due to non-breaking change
db8ee8c 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
typo
bebcd64 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel bso-intel marked this pull request as ready for review December 23, 2020 16:50
@bso-intel bso-intel requested review from a team and smaslov-intel as code owners December 23, 2020 16:50
@bso-intel
Copy link
Contributor Author

bso-intel commented Dec 23, 2020

@smaslov-intel @romanovvlad @alexbatashev
Please review.
Please note that this PR is not intended to fix all remaining memory leaks yet.
This is a required step to fix the other memory leaks.

alexbatashev
alexbatashev reviewed Dec 23, 2020
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have some testing and a brief design overview here: https://github.com/intel/llvm/blob/sycl/sycl/doc/GlobalObjectsInRuntime.md

@bso-intel
Copy link
Contributor Author

bso-intel commented Dec 23, 2020

Would be great to have some testing and a brief design overview here: https://github.com/intel/llvm/blob/sycl/sycl/doc/GlobalObjectsInRuntime.md

I will write something based on my design doc (ppt) today.

@bso-intel bso-intel mentioned this pull request Dec 23, 2020
Closed
@bso-intel
added plugin lifetime design overview in doc
43eb187 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
alexbatashev
alexbatashev reviewed Dec 24, 2020
View reviewed changes
romanovvlad
romanovvlad reviewed Dec 24, 2020
View reviewed changes
bso-intel and others added 11 commits December 24, 2020 11:19
@bso-intel @alexbatashev
Update sycl/doc/GlobalObjectsInRuntime.md
d0d2a5d 
Co-authored-by: Alexander Batashev <alexbatashev@outlook.com>
@bso-intel @romanovvlad
Update sycl/include/CL/sycl/detail/pi.h
1831f10 
Co-authored-by: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com>
@bso-intel @romanovvlad
Update sycl/source/detail/global_handler.cpp
52a3887 
Co-authored-by: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com>
@bso-intel @romanovvlad
Update sycl/include/CL/sycl/detail/pi.h
f49ad91 
Co-authored-by: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com>
@bso-intel
Respond to feedbacks
7c283af 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
Change var plgn to Plugin
1d83fd4 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
add a placeholder parameter to piTearDown
f17070f 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
clang-format
ebeec30 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
fixed wrong function to add param
aa5a252 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
added placeholder parameter to piteardown
5ae6900 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
clang-format
4fa8ef5 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
romanovvlad
romanovvlad reviewed Dec 25, 2020
View reviewed changes
bso-intel and others added 5 commits December 25, 2020 08:12
@bso-intel @romanovvlad
Update sycl/plugins/level_zero/pi_level_zero.cpp
25e1f6d 
Co-authored-by: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com>
@bso-intel @romanovvlad
Update sycl/doc/GlobalObjectsInRuntime.md
f6e51ad 
Co-authored-by: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com>
@bso-intel @romanovvlad
Update sycl/doc/GlobalObjectsInRuntime.md
3386693 
Co-authored-by: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com>
@bso-intel
Merge branch 'sycl' into plugin-lifetime
f1f1cd2
@bso-intel
respond to further feedback
bcc6a76 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
romanovvlad
romanovvlad reviewed Dec 28, 2020
View reviewed changes
bso-intel and others added 2 commits December 28, 2020 08:23
@bso-intel @romanovvlad
Update sycl/plugins/level_zero/pi_level_zero.cpp
633779d 
Co-authored-by: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com>
@bso-intel @romanovvlad
Update sycl/plugins/level_zero/pi_level_zero.cpp
975331e 
Co-authored-by: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com>
@bso-intel
Copy link
Contributor Author

bso-intel commented Dec 28, 2020

@smaslov-intel Please review.

@bso-intel
redrew diagram of plugin lifetime
370fc34 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
romanovvlad
romanovvlad reviewed Dec 29, 2020
View reviewed changes
sycl/doc/GlobalObjectsInRuntime.md
plugin. piTearDown() is going to perform any necessary tear-down process at the
plugin PI level. These two APIs allow on-demand plugin lifetime management. SYCL
RT can control the beginning and the end of the plugin.
![](images/plugin-lifetime.jpg)
Copy link
Contributor

@romanovvlad romanovvlad Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add arrow with piPluginInit label, which goes from "Plugin Interface" to "Plugin", it should correspond to "bind plugin" arrow?
Also, could you please rename "destory plugin" to piTearDown?

bso-intel and others added 4 commits December 29, 2020 08:26
@bso-intel @romanovvlad
Update sycl/doc/GlobalObjectsInRuntime.md
2528756 
Co-authored-by: Romanov Vlad <17316488+romanovvlad@users.noreply.github.com>
@bso-intel
Fixed the diagram labels.
77a5c73 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
Merge branch 'plugin-lifetime' of https://github.com/bso-intel/llvm i…
f26f54e 
…nto plugin-lifetime
@bso-intel
missed picture
63d0a4c 
Signed-off-by: Byoungro So <byoungro.so@intel.com>
@bso-intel
Copy link
Contributor Author

bso-intel commented Dec 29, 2020

The failure in Jenkins/Precommit is not caused by my changeset.
It seems the latest change in Jenkins/Precommit introduced this failure.
The latest 'sycl' branch already has this issue.

@romanovvlad romanovvlad merged commit f58c568 into intel:sycl Dec 30, 2020
@bso-intel
Copy link
Contributor Author

bso-intel commented Dec 30, 2020

Thank you very much, Vlad.

@bso-intel bso-intel deleted the plugin-lifetime branch January 11, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romanovvlad romanovvlad romanovvlad approved these changes

@smaslov-intel smaslov-intel Awaiting requested review from smaslov-intel

+1 more reviewer

@alexbatashev alexbatashev alexbatashev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bso-intel @alexbatashev @romanovvlad