Skip to content

[SYCL] Add clang-offload-deps tool to the deploy list #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2021
Merged

[SYCL] Add clang-offload-deps tool to the deploy list #2973

merged 1 commit into from
Jan 4, 2021

Conversation

sndmitriev
Copy link
Contributor

Signed-off-by: Sergey Dmitriev serguei.n.dmitriev@intel.com

@sndmitriev
[SYCL] Add clang-offload-deps tool to the deploy list
4f185e7 
Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
@sndmitriev sndmitriev requested a review from a team as a code owner December 31, 2020 02:38
@v-klochkov
Copy link
Contributor

Please add a comment in this PR - why clang-offload-deps must be added to deploy list now?
Is it required for some feature being developed or it is to fix some known problem?

@sndmitriev
Copy link
Contributor Author

Please add a comment in this PR - why clang-offload-deps must be added to deploy list now?
Is it required for some feature being developed or it is to fix some known problem?

Yes, driver needs this tool after #2935, but it has not been added to the deploy list.

@vladimirlaz
Copy link
Contributor

Please add a comment in this PR - why clang-offload-deps must be added to deploy list now?
Is it required for some feature being developed or it is to fix some known problem?

Yes, driver needs this tool after #2935, but it has not been added to the deploy list.

can we add a test to llvm-test-suite to test new tool?

@sndmitriev
Copy link
Contributor Author

Please add a comment in this PR - why clang-offload-deps must be added to deploy list now?
Is it required for some feature being developed or it is to fix some known problem?

Yes, driver needs this tool after #2935, but it has not been added to the deploy list.

can we add a test to llvm-test-suite to test new tool?

It actually already has tests which depend on a presence of this tool in deploy directory. That is how I figured out that this tool was not deployed.

@v-klochkov v-klochkov merged commit 237675b into intel:sycl Jan 4, 2021
@sndmitriev sndmitriev deleted the public/sndmitriev/deploy-clang-offload-deps branch January 4, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirlaz vladimirlaz vladimirlaz approved these changes

@v-klochkov v-klochkov v-klochkov approved these changes

@romanovvlad romanovvlad Awaiting requested review from romanovvlad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sndmitriev @v-klochkov @vladimirlaz