Skip to content

Fix the clang-tidy build after work_group_size attr changes. #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2021
Merged

Fix the clang-tidy build after work_group_size attr changes. #3016

merged 3 commits into from
Jan 12, 2021

Conversation

AaronBallman
Copy link
Contributor

SingleWorkItemBarrierCheck.cpp from upstream does not work with our
recent changes in ca9d816. This
addresses the issue by adding some helper methods to the work group
size attributes and using them where appropriate.

@AaronBallman
Fix the clang-tidy build after work_group_size attr changes.
c9a8fcf 
SingleWorkItemBarrierCheck.cpp from upstream does not work with our
recent changes in ca9d816. This
addresses the issue by adding some helper methods to the work group
size attributes and using them where appropriate.
@AaronBallman
Copy link
Contributor Author

This addresses #3011.

@AaronBallman AaronBallman requested a review from smanna12 January 11, 2021 21:02
elizabethandrews
elizabethandrews previously approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

premanandrao
premanandrao previously approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bader
bader reviewed Jan 12, 2021
View reviewed changes
@bader bader dismissed stale reviews from premanandrao and elizabethandrews via 70f9529 January 12, 2021 07:47
@AaronBallman
Copy link
Contributor Author

@bader -- good catch on those formatting changes, I guess clang-format doesn't see into .td files!

@bader bader merged commit 42c09e3 into intel:sycl Jan 12, 2021
@bader bader linked an issue Jan 12, 2021 that may be closed by this pull request
clang-tidy fails to build in the latest code #3011
Closed
@bader bader mentioned this pull request Jan 12, 2021
Closed
iclsrc pushed a commit that referenced this pull request Dec 5, 2023
@vfdff
[CGP][AArch64] Rebase the common base offset for better ISel
d6f4d52 
When all the large const offsets masked with the same value from bit-12 to bit-23.
Fold
  add     x8, x0, #2031, lsl #12
  add     x8, x8, #960
  ldr     x9, [x8, x8]
  ldr     x8, [x8, #2056]

into
  add     x8, x0, #2031, lsl #12
  ldr     x9, [x8, #960]
  ldr     x8, [x8, #3016]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@premanandrao premanandrao premanandrao left review comments

@elizabethandrews elizabethandrews elizabethandrews left review comments

@smanna12 smanna12 Awaiting requested review from smanna12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clang-tidy fails to build in the latest code
4 participants
@AaronBallman @bader @premanandrao @elizabethandrews