Skip to content

[SYCL][NFC] Fix typos in test code comments #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Conversation

smanna12
Copy link
Contributor

This patch updates tests related to work_group_size attributes by fixing
typos and adding CHECK that happened on commit #2906

Signed-off-by: Soumi Manna soumi.manna@intel.com

This patch updates tests related to work_group_size attributes by fixing
typos and adding CHECK that happened on commit intel#2906

Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smanna12 smanna12 marked this pull request as ready for review January 25, 2021 15:35
@smanna12
Copy link
Contributor Author

LGTM!

Thanks @AaronBallman

Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smanna12
Copy link
Contributor Author

smanna12 commented Jan 25, 2021

Thanks!

Thanks for the review.

@bader bader merged commit f295e78 into intel:sycl Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants