[SYCL] Fix long long support in vec::convert on Windows #3097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/summary:run |
- Keep `long long` and `unsigned long long` in `is_standard_type`. Excluding them resulted in duplicate `convertImpl` definitions on Windows when converting from `long long` or `unsigned long long`: SPIR-V-based and the non-standard type version. - For to-int SPIR-V-based `convertImpl` overload resolution, compare the OpenCL return type with cl_DestType instead of simply DestType ((u)char, (u)short, (u)int, (u)long). When converting to `long long` or `unsigned long long` on Windows, the non-standard type version was used instead of these functions, because `cl_long == long long != long` there.
dnmokhov
changed the title
Contributor
Author
|
/summary:run |
Contributor
|
@bader @turinevgeny Could you please review? |
romanovvlad
reviewed
Feb 2, 2021
bader
reviewed
Feb 2, 2021
romanovvlad
approved these changes
Feb 2, 2021
bader
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long longandunsigned long longinis_standard_type.Excluding them resulted in duplicate
convertImpldefinitions onWindows when converting from
long longorunsigned long long:SPIR-V-based and the non-standard type version.
convertImploverload resolution, comparethe OpenCL return type with cl_DestType instead of simply DestType
((u)char, (u)short, (u)int, (u)long). When converting to
long longor
unsigned long longon Windows, the non-standard type versionwas used instead of these functions, because
cl_long == long long != longthere.