[NFC][ESIMD] Remove one of the uses of __SYCL_EXPLICIT_SIMD__ #3242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is a part of the efforts for allowing ESIMD and regular SYCL kernels to coexist in the same translation unit and in the same program. In ESIMD kernels, calls to __spirv_ functions are lowered into GenX intrinsic. Because of that, it's OK to have definitions instead of declarations for those functions. Unused definitions of __spirv_ functions will be DCE'ed anyway, so no impact on functionality.
sergey-semenov
approved these changes
Feb 24, 2021
romanovvlad
pushed a commit
that referenced
this pull request
Feb 26, 2021
DenisBakhvalov
added a commit
to DenisBakhvalov/llvm
that referenced
this pull request
Mar 5, 2021
…__ (intel#3242)" This patch is a part of the efforts for allowing ESIMD and regular SYCL kernels to coexist in the same translation unit and in the same program. Previously, in ESIMD device code we had calls to SPIRV intrinsics that didn't have definitions. With the change in spirv_vars.hpp, SYCL optimization passes convert calls to SPIRV intrinsics into loads from globals (SPIRV builtins). Thus, there is a need to change the implementation of LowerESIMD pass to lower such new constructs. Example: // @__spirv_BuiltInGlobalInvocationId = external dso_local local_unnamed_addr addrspace(1) constant <3 x i64>, align 32 // ... // %0 = load <3 x i64>, <3 x i64> addrspace(4)* addrspacecast // (<3 x i64> addrspace(1)* @__spirv_BuiltInLocalInvocationId // to <3 x i64> addrspace(4)*), align 32 // %1 = extractelement <3 x i64> %0, i64 0 // // => // // %.esimd = call <3 x i32> @llvm.genx.local.id.v3i32() // %local_id.x = extractelement <3 x i32> %.esimd, i32 0 // %local_id.x.cast.ty = zext i32 %local_id.x to i64 Current tests in sycl/test/esimd/spirv_intrins_trans.cpp check that there is no regression in how we lower SPRIV intrinsics into GenX counterparts. But also, I added some more tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a part of the efforts for allowing ESIMD and
regular SYCL kernels to coexist in the same translation unit and
in the same program.
In ESIMD kernels, calls to _spirv functions are lowered into GenX intrinsic.
Because of that, it's OK to have definitions instead of declarations for those functions.
Unused definitions of _spirv functions will be DCE'ed anyway, so no impact on functionality.