[SYCL] Refactor of two FPGA function attributes #3274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch 1. refactors two function attributes: [[intel::no_global_work_offset()]] and [[intel::scheduler_target_fmax_mhz()]] using intel#3224 as a template to better fit for community standards. 2. refactors the way we handle duplicate attributes on a given declaration. 3. handles redeclarations or template instantiations properly. 4. adds test Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Thanks Aaron for the reviews. |
elizabethandrews
approved these changes
Mar 1, 2021
|
Thanks @elizabethandrews for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch
[[intel::no_global_work_offset()]] and [[intel::scheduler_target_fmax_mhz()]]
using [SYCL] Refactor the way we handle duplicate attribute logic #3224 as a template to better fit for community standards.
Signed-off-by: Soumi Manna soumi.manna@intel.com