Skip to content

[SYCL] Refactor of FPGA loop fusion function attributes #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 7, 2021
Merged

[SYCL] Refactor of FPGA loop fusion function attributes #3298

merged 6 commits into from
Mar 7, 2021

Conversation

smanna12
Copy link
Contributor

@smanna12 smanna12 commented Mar 3, 2021 •
edited
Loading

This patch

  1. refactors two function attributes using [SYCL] Refactor the way we handle duplicate attribute logic #3224 :
    [[intel::loop_fuse()]] and [[intel::loop_fuse_independent()]]
  2. stores expression as ConstantExpr in Semantic Attributes
  3. handles template instantiations properly for duplicate attributes on a given declaration.
  4. adds test
  5. updates codegen codes

Signed-off-by: Soumi Manna soumi.manna@intel.com

smanna12 added 2 commits March 3, 2021 11:14
@smanna12
[SYCL] Refactor of FPGA loop fusion function attributes
b5f761f 
This patch
 1. refactors two function attributes using intel#3224 :
    [[intel::loop_fuse()]] and [[intel::loop_fuse_independent()]]
 2. store expression as ConstantExpr in Semantic Attributes
 3. handles template instantiations properly for duplicate attributes on a given declaration.
 4. adds test
 5. updates codegen codes

Signed-off-by: Soumi Manna <soumi.manna@intel.com>
@smanna12
Fix errors
8791b00 
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
smanna12 commented Mar 3, 2021
View reviewed changes
@smanna12 smanna12 requested a review from AaronBallman March 3, 2021 19:36
AaronBallman
AaronBallman reviewed Mar 4, 2021
View reviewed changes
@smanna12
Address review comments
24245f1 
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
AaronBallman
AaronBallman reviewed Mar 4, 2021
View reviewed changes
smanna12 added 2 commits March 4, 2021 07:46
@smanna12
update patch
b3f9560 
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
@smanna12
remove assert
579fd64 
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
AaronBallman
AaronBallman previously approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smanna12
Copy link
Contributor Author

smanna12 commented Mar 4, 2021

LGTM!

Thanks Aaron.

@smanna12 smanna12 marked this pull request as ready for review March 4, 2021 15:50
premanandrao
premanandrao reviewed Mar 5, 2021
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Can you please add comments at the top of the tests to indicate what they are testing for?

@smanna12
Add comments in each tests
a3b90d2 
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
@smanna12
Copy link
Contributor Author

smanna12 commented Mar 5, 2021

Changes look good to me. Can you please add comments at the top of the tests to indicate what they are testing for?

Thank you. Done

premanandrao
premanandrao approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smanna12
Copy link
Contributor Author

smanna12 commented Mar 5, 2021

LGTM

Thanks Prem

@bader bader merged commit 628bc0c into intel:sycl Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premanandrao premanandrao premanandrao approved these changes

@elizabethandrews elizabethandrews Awaiting requested review from elizabethandrews

@AaronBallman AaronBallman Awaiting requested review from AaronBallman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smanna12 @AaronBallman @premanandrao @bader