[ESIMD] Let ESIMD attributes not depend on -fsycl-explicit-simd #3446
Conversation
DenisBakhvalov
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
|
I'd appreciate a bit more information about why the change is being made (added to the PR description so it goes into the commit message). Are no tests impacted by this change? We should add test coverage to show this is explicitly supported. |
Yes, sorry, will do. I just wanted to check the ESIMD on-GPU tests in the llvm-test-suite. I believe converting to draft will stop the CI, right? |
Good question! I think converting to a draft still runs the CI pipeline but I'm not 100% sure. |
kbobrovs
left a comment
kbobrovs
left a comment
There was a problem hiding this comment.
Denis, can you please update the docs too - the ESIMD intro and spec.
I will. Is it OK if I update the docs in a separate patch once all the changes regarding SYCL-ESIMD coexistence will be done? |
Yes, that should be Ok |
4 participants
This is one of the final patches to support mixing SYCL and ESIMD kernels.
In the end, we want to get rid of
-fsycl-explicit-simdoption and unify the two modes: regular SYCL and ESIMD.This patch eliminates one of the dependencies on the
-fsycl-explicit-simdflag, allowing to use ESIMD attributes without it.