Skip to content

[SYCL] [DOC] Prepare design-document for assert feature #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
May 31, 2021
+602 −0
Merged

[SYCL] [DOC] Prepare design-document for assert feature #3461

Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
2911ea7
[SYCL] [DOC] Prepare design-document for assert feature
Mar 31, 2021
b69a1cd
Remove redundant file
Mar 31, 2021
15ea88e
Fix typo
Apr 1, 2021
ca08fec
Address some review comments. Add description of built-ins.
Apr 5, 2021
1f8d9a9
Fix links
Apr 5, 2021
2ee590c
Clarify that assertion failure message is printed by DPCPP Runtime
Apr 5, 2021
77699a2
Clarify that fallback assert impl is synchronous
Apr 6, 2021
001a573
Fix typo in level-zero ext draft
Apr 6, 2021
32b6479
Address some review comments.
Apr 7, 2021
b8637c2
Add exception extension
Apr 8, 2021
b0cd85f
Use error-code instead of distinct exception.
Apr 8, 2021
8c03648
[SYCL] Add OpenCL extension for assert error code
Apr 9, 2021
121c945
[SYCL] Add Level-Zero extension for assert error code
Apr 9, 2021
13b40fd
Merge branch 'private/s-kanaev/assert-ocl-l0' into private/s-kanaev/a…
Apr 9, 2021
a4b4884
Remove draft files
Apr 9, 2021
c06db5f
Remove unwanted part
Apr 9, 2021
823124a
Merge branch 'private/s-kanaev/assert-ocl-l0' into private/s-kanaev/a…
Apr 9, 2021
a99368b
Add limitations on submit to same queue after exception thrown.
Apr 9, 2021
78d7fcb
Add format of assert message
Apr 9, 2021
6882e95
Clarify where kernel wrapping takes place
Apr 9, 2021
32663e0
Changes to SYCL specification
Apr 13, 2021
2b84a83
Elaborate on limitations
Apr 13, 2021
423107b
Fix link
Apr 14, 2021
7611511
Add sequence describing how DPCPP RT gets to know about assert failure
Apr 14, 2021
a31b808
Add notes on property set usage
Apr 14, 2021
257054a
Address comments
Apr 14, 2021
3f50173
Fix typo and format note
Apr 14, 2021
c1326aa
Fix typo
Apr 14, 2021
5095b1a
Add extension to README
Apr 14, 2021
5078fcc
Note on how property set gets to be set
Apr 14, 2021
4dc7b1f
Merge branch 'sycl' into private/s-kanaev/assert-abort
Apr 15, 2021
9bcac02
Partially remove mentioning of async exception throw
Apr 15, 2021
7ec3ac8
Add Assert.md to index
Apr 15, 2021
8cbfde7
Remove the rest of exception throws
Apr 15, 2021
cc085f5
Address review comments
Apr 22, 2021
8835bf8
Document program-scope variable approach
May 6, 2021
8835756
Merge remote-tracking branch 'public/sycl' into private/s-kanaev/asse…
May 6, 2021
ecb8659
Remove L0 and OCL extensions.
May 7, 2021
07debdb
Address comments
May 11, 2021
995e4d8
Fix typo
May 12, 2021
b57ac48
Fix typo
May 12, 2021
d2f13ff
Address review comments
May 17, 2021
6281bc5
Switch to __devicelib_assert_read
May 19, 2021
a5461f3
Remove use of NDEBUG from suggested changes
May 19, 2021
32a32f4
Reorder text to increase readability
May 19, 2021
641d071
Address review comment
May 20, 2021
dc058a9
Address review comments
May 27, 2021
16fd8f0
Add aspect
May 27, 2021
fbca768
Update extension with suggestion
s-kanaev May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading