Skip to content

[SYCL] Add support multidimensional subscript for atomic accessor #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 4 commits into from
Apr 6, 2021
Merged

[SYCL] Add support multidimensional subscript for atomic accessor #3473

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f18ea54
[SYCL] Add support multidimensional subscript for atomic accessor
maximdimakov Apr 2, 2021
fe20c34
clang-format fix
maximdimakov Apr 2, 2021
113ea54
Address review comment
maximdimakov Apr 2, 2021
5967c03
Clang-format fix
maximdimakov Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sycl/include/CL/sycl/accessor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,8 @@ class accessor_common {
constexpr static bool IsAccessReadWrite =
AccessMode == access::mode::read_write;

constexpr static bool IsAccessAtomic = AccessMode == access::mode::atomic;

using RefType = detail::const_if_const_AS<AS, DataT> &;
using ConstRefType = const DataT &;
using PtrType = detail::const_if_const_AS<AS, DataT> *;
Expand Down Expand Up @@ -325,6 +327,14 @@ class accessor_common {
return MAccessor[MIDs];
}

template <int CurDims = SubDims>
typename detail::enable_if_t<CurDims == 1 && IsAccessAtomic,
atomic<DataT, AS>>
operator[](size_t Index) const {
MIDs[Dims - CurDims] = Index;
return MAccessor[MIDs];
}

template <int CurDims = SubDims,
typename = detail::enable_if_t<CurDims == 1 && IsAccessReadOnly>>
ConstRefType operator[](size_t Index) const {
Expand Down