Skip to content

[SYCL] Rework MarkDevice and children #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 9, 2021
Merged

[SYCL] Rework MarkDevice and children #3475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1880471
[SYCL] Rework MarkDevice and children
Apr 1, 2021
dc10304
Clang-format fixes
Apr 2, 2021
c51a88c
Add test to ensure constexpr-if inactive branches work
Apr 2, 2021
aa44fd9
Remove copy paste comment error
Apr 2, 2021
9efd1f4
Remove some 'proven' todos, combine attribute collection checks
Apr 2, 2021
91eabf3
Merge branch 'sycl' into mark_device_rewrite
Apr 2, 2021
efb756e
document the new types
Apr 6, 2021
d2e3531
Apply Prem's suggestions
Apr 7, 2021
569250b
A bunch of fixups as suggested by Aaron
Apr 7, 2021
99747fd
Clang-format fix
Apr 7, 2021
bda527d
Add more const, mess with sycl-simd in switch
Apr 8, 2021
ca07344
Merge branch 'sycl' into mark_device_rewrite
Apr 8, 2021
83444aa
Remove newline inadvertently added during the 'merge'
Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/include/clang/Sema/Sema.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13182,7 +13182,7 @@ class Sema final {
void checkSYCLDeviceVarDecl(VarDecl *Var);
void copySYCLKernelAttrs(const CXXRecordDecl *KernelObj);
void ConstructOpenCLKernel(FunctionDecl *KernelCallerFunc, MangleContext &MC);
void MarkDevice();
void MarkDevices();

/// Emit a diagnostic about the given attribute having a deprecated name, and
/// also emit a fixit hint to generate the new attribute name.
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Sema/Sema.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1039,7 +1039,7 @@ void Sema::ActOnEndOfTranslationUnitFragment(TUFragmentKind Kind) {
SyclIntHeader->emit(getLangOpts().SYCLIntHeader);
if (SyclIntFooter != nullptr)
SyclIntFooter->emit(getLangOpts().SYCLIntFooter);
MarkDevice();
MarkDevices();
}

emitDeferredDiags();
Expand Down
Loading