[ESIMD] Add support for vectorizing scalar functions - FE part #3603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is one of the few patches to provide a functionality to reuse existing scalar function implementations in a vector context. For example, based on scalar version of `float cos(float)`, implement simd<float,N> cos(simd<float,N>) - "widened" version of the original scalar function. To achieve that, we mark such functions with `sycl_esimd_widen` attribute which will be later used by vector compiler backend to widen it. For now, this functionality will be used only in internal implementation of specific public ESIMD APIs. It is not supposed to be used directly in the user code. It is a temporary solution to enable ESIMD math functions by reusing existing scalar implementations. Later it is supposed to be replaced by a more generic mechanism.
DenisBakhvalov
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
kbobrovs
reviewed
Apr 23, 2021
DenisBakhvalov
changed the title
elizabethandrews
previously approved these changes
Apr 29, 2021
DenisBakhvalov
dismissed stale reviews from elizabethandrews and AaronBallman
via
44cc121
This reverts commit 44cc121.
kbobrovs
approved these changes
May 4, 2021
elizabethandrews
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is one of the few patches to provide a functionality to reuse
existing scalar function implementations in a vector context.
For example, based on scalar version of
float cos(float), implementsimd<float,N> cos(simd<float,N>) - "widened" version of the original
scalar function.
To achieve that, we mark such functions with
sycl_esimd_widenattributewhich will be later used by vector compiler backend to widen it.
For now, this functionality will be used only in internal implementation of
specific public ESIMD APIs. It is not supposed to be used directly in the
user code. It is a temporary solution to enable ESIMD math functions by
reusing existing scalar implementations. Later it is supposed to be
replaced by a more generic mechanism.