[SYCL] Fix integration-footer anon-NS handling to return right value #3669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like I got carried away with the implementation and we didn't catch that I was returning the wrong things from the 'end call function' when generating anonymous function shims. This was brought up here: intel#3576 (review) This should fix that problem.
erichkeane
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
premanandrao
approved these changes
Apr 30, 2021
Contributor
premanandrao
left a comment
premanandrao
left a comment
There was a problem hiding this comment.
LGTM
(but FWIW, I missed the issue the last time ;-) )
AlexeySachkov
approved these changes
Apr 30, 2021
Contributor
Author
|
Oh dear... this seems to have caused an ICE in the MSVC compiler! Not sure what i can do to fix the Precommit check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I got carried away with the implementation and we didn't
catch that I was returning the wrong things from the 'end call function'
when generating anonymous function shims. This was brought up here:
#3576 (review)
This should fix that problem.