[SYCL] Add the 'cl' inline namespace to the integration footer- #3752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlad Romanov brought up that we'd missed this in the initial implementation, so add it so that the 'cl' namespace is correctly included.
erichkeane
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
AaronBallman
previously approved these changes
May 13, 2021
Contributor
AaronBallman
left a comment
AaronBallman
left a comment
There was a problem hiding this comment.
LGTM but a possible minor refactoring that I don't insist on.
erichkeane
dismissed stale reviews from premanandrao and AaronBallman
via
f85ee0a
romanovvlad
approved these changes
May 14, 2021
elizabethandrews
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vlad Romanov brought up that we'd missed this in the initial
implementation, so add it so that the 'cl' namespace is correctly
included.