[SYCL][FPGA] Apply [[intel::use_stall_enable_clusters]] attribute to any function #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vladimirlaz merged 19 commits into intel:sycl from smanna12:ApplyAttrAnyFunction

Jun 17, 2021

Contributor

smanna12 commented Jun 8, 2021 •

edited

Loading

[[intel::use_stall_enable_clusters]] is a function attribute, not a kernel one.
It can be applied to any function or lambda. This patch removes the
incorrect behavior that was added on PR: #2734 where
the metadata to be attached to the FunctionDecl/IR Function that the attribute is applied to.

Signed-off-by: Soumi Manna soumi.manna@intel.com

smanna12 added 2 commits

June 8, 2021 14:11


          [SYCL][FPGA] Apply [[intel::use_stall_enable_clusters]] attribute to …

f2df511

…ANY function

[[intel::use_stall_enable_clusters]] is a function attribute, not a kernel one.
It can be applied to any function or lambda. This patch removes the
restriction that was added on PR: intel#2734 to allow
propagating the attribute to kernel if it is applied to any function the kernel calls.

Signed-off-by: Soumi Manna <soumi.manna@intel.com>


          update doc

b2ecda7

Signed-off-by: Soumi Manna <soumi.manna@intel.com>

smanna12 changed the title ~~[SYCL][FPGA] Apply [[intel::use_stall_enable_clusters]] attribute to …~~ [SYCL][FPGA] Apply [[intel::use_stall_enable_clusters]] attribute to any function


          fix clang format issues

2ce3bc3

Signed-off-by: Soumi Manna <soumi.manna@intel.com>

smanna12 marked this pull request as ready for review

June 8, 2021 21:26

smanna12 requested review from AaronBallman, elizabethandrews and premanandrao as code owners

June 8, 2021 21:26

smanna12 requested review from erichkeane and mendell27

June 8, 2021 21:26

erichkeane reviewed

View reviewed changes

clang/lib/Sema/SemaSYCL.cpp Show resolved Hide resolved

smanna12 added 2 commits

June 9, 2021 08:20


          address review comments

4d76f3e

Signed-off-by: Soumi Manna <soumi.manna@intel.com>


          fix clang format errors

63cb9f5

Signed-off-by: Soumi Manna <soumi.manna@intel.com>

smanna12 requested a review from erichkeane

June 9, 2021 15:27

erichkeane reviewed

View reviewed changes

clang/lib/CodeGen/CodeGenFunction.cpp Outdated Show resolved Hide resolved

clang/lib/CodeGen/CodeGenFunction.cpp Outdated Show resolved Hide resolved

elizabethandrews reviewed

View reviewed changes

clang/include/clang/Basic/AttrDocs.td Outdated Show resolved Hide resolved

smanna12 added 3 commits

June 9, 2021 08:52


          address review comments

54347d2

Signed-off-by: Soumi Manna <soumi.manna@intel.com>


          fix format issues

d0a6ac8

Signed-off-by: Soumi Manna <soumi.manna@intel.com>


          address review comments

5e226a0

Signed-off-by: Soumi Manna <soumi.manna@intel.com>

smanna12 requested review from elizabethandrews and erichkeane

June 9, 2021 22:56

elizabethandrews reviewed

View reviewed changes

clang/include/clang/Basic/AttrDocs.td Outdated Show resolved Hide resolved

clang/include/clang/Basic/AttrDocs.td Show resolved Hide resolved

clang/lib/Sema/SemaSYCL.cpp Outdated Show resolved Hide resolved

clang/test/CodeGenSYCL/stall_enable_device.cpp Outdated Show resolved Hide resolved

clang/test/CodeGenSYCL/stall_enable_host.cpp Show resolved Hide resolved

smanna12 added 3 commits

June 11, 2021 07:59


          address review comments

fddae48

Signed-off-by: Soumi Manna <soumi.manna@intel.com>


          update Doc

10dd6ff

Signed-off-by: Soumi Manna <soumi.manna@intel.com>


          Merge remote-tracking branch 'my_remote/sycl' into ApplyAttrAnyFunction

8ebc290

smanna12 requested a review from elizabethandrews

June 14, 2021 14:26


          generate the metadata in device-mode

4dac683

Signed-off-by: Soumi Manna <soumi.manna@intel.com>

elizabethandrews reviewed

View reviewed changes

clang/include/clang/Basic/AttrDocs.td Outdated Show resolved Hide resolved

clang/test/CodeGenSYCL/stall_enable_device.cpp Outdated Show resolved Hide resolved

clang/test/SemaSYCL/stall_enable_device.cpp Show resolved Hide resolved

clang/test/SemaSYCL/stall_enable_host.cpp Outdated Show resolved Hide resolved

smanna12 added 2 commits

June 14, 2021 09:42


          address review comments

8da68a8

Signed-off-by: Soumi Manna <soumi.manna@intel.com>


          update doc

a57d932

Signed-off-by: Soumi Manna <soumi.manna@intel.com>

smanna12 added 3 commits

June 14, 2021 09:53


          add comments in test

dbbacf0

Signed-off-by: Soumi Manna <soumi.manna@intel.com>


          update tests

a916048

Signed-off-by: Soumi Manna <soumi.manna@intel.com>


          update Sema/CodeGen tests and add comments

Signed-off-by: Soumi Manna <soumi.manna@intel.com>

AaronBallman reviewed

View reviewed changes

clang/include/clang/Basic/AttrDocs.td Show resolved Hide resolved

clang/include/clang/Basic/AttrDocs.td Show resolved Hide resolved

clang/lib/CodeGen/CodeGenFunction.cpp Outdated Show resolved Hide resolved

smanna12 added 2 commits

June 14, 2021 12:28


          address review comments

91a94c3

Signed-off-by: Soumi Manna <soumi.manna@intel.com>


          update doc based on aaron's comment

1d5b16f

Signed-off-by: Soumi Manna <soumi.manna@intel.com>

smanna12 requested a review from AaronBallman

June 15, 2021 12:31

AaronBallman approved these changes

View reviewed changes

Contributor

AaronBallman left a comment

LGTM!

smanna12 requested a review from elizabethandrews

June 15, 2021 15:20

Contributor Author

smanna12 commented Jun 15, 2021

LGTM!

Thanks Aaron.

elizabethandrews approved these changes

View reviewed changes

Contributor

elizabethandrews left a comment

Thank you!

Contributor Author

smanna12 commented Jun 15, 2021 •

edited

Loading

Thanks you everyone for the reviews and discussion.

Contributor Author

smanna12 commented Jun 17, 2021

@vladimirlaz, could you please merge this PR? Thanks.

vladimirlaz merged commit 15da879 into intel:sycl

smanna12 mentioned this pull request

[SYCL][FPGA] Allow use_stall_enable_clusters attribute to kernel #4031

Merged

AaronBallman pushed a commit that referenced this pull request


          [SYCL][FPGA] Allow use_stall_enable_clusters attribute to kernel (#4031)

06e4ebc

This patch collects and applies the FPGA attribute intel::use_stall_enable_clusters to the callers/SYCL kernel if directly applied through functors/lambda function.

The attribute has to be applicable to all functions, which can include the SYCL kernels and must not be propagated up to the caller/SYCL kernel when called from a function.

This patch fixes FPGA emulator bug that was introduced on #3900.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AaronBallman AaronBallman approved these changes

elizabethandrews elizabethandrews approved these changes

premanandrao Awaiting requested review from premanandrao

mendell27 Awaiting requested review from mendell27

erichkeane Awaiting requested review from erichkeane

Labels

None yet