[SYCL][CUDA] Skip PiCudaTests when running other plugins #4103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where if the cuda plugin is enabled and lit tests for another plugin are run, it will try to run PiCudaTests, and all of them will assert since the device filter will be set to a non-cuda plugin and the tests request a cuda device. So instead of asserting this patch makes the PiCudaTests get marked as skipped if there is no cuda device found.
bader
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where if the cuda plugin is enabled and lit tests
for another plugin are run, it will try to run PiCudaTests, and all of
them will assert since the device filter will be set to a non-cuda
plugin and the tests request a cuda device.
So instead of asserting this patch makes the PiCudaTests get marked as
skipped if there is no cuda device found.