[SYCL][L0] Experimental options for fine-tune of dynamic batching #4492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
reviewed
Sep 5, 2021
romanovvlad
reviewed
Sep 9, 2021
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
smaslov-intel
force-pushed
the
dynbatch
branch
from
c76eb45 to
765a9ed
Compare
romanovvlad
approved these changes
Sep 10, 2021
|
|
||
| static const pi_uint32 ZeCommandListBatchSize = [] { | ||
| // Configuration of the command-list batching. | ||
| typedef struct { |
Contributor
There was a problem hiding this comment.
I'm trying to build on Windows today, and I'm getting this error on this struct:
C:\iusers\cperkins\sycl_workspace\llvm\sycl\plugins\level_zero\pi_level_zero.cpp(850): error C2220: the following warning is treated as an error
C:\iusers\cperkins\sycl_workspace\llvm\sycl\plugins\level_zero\pi_level_zero.cpp(850): warning C5208: unnamed class used in typedef name cannot declare members other than non-static data members, member enumerations, or member classes
But the CI was able to build and pass. I tried building from scratch with our python script and no luck. MSVC 2019 I think on the Win dev machine.
Contributor
Author
There was a problem hiding this comment.
Would you type-name the struct to avoid possible errors? (since you can verify this)
Contributor
There was a problem hiding this comment.
@smaslov-intel - yeah, that was it.
I opened a newer PR that includes that fix: #4557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com