[SYCL] Remove the offset field from item<dimensions, false> class. #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
requested changes
Aug 8, 2019
alexeyvoronov-intel
force-pushed
the
private/avoronov/item_class_refactoring
branch
2 times, most recently
from
1757080 to
2a67c49
Compare
romanovvlad
previously approved these changes
Aug 12, 2019
Signed-off-by: Alexey Voronov <alexey.voronov@intel.com>
Moved part of logic from item class to new class item_base to hide implementation details. Signed-off-by: Alexey Voronov <alexey.voronov@intel.com>
alexeyvoronov-intel
force-pushed
the
private/avoronov/item_class_refactoring
branch
from
2a67c49 to
dc583f7
Compare
romanovvlad
approved these changes
Aug 13, 2019
romanovvlad
approved these changes
Aug 13, 2019
alexeyvoronov-intel
deleted the
private/avoronov/item_class_refactoring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexey Voronov alexey.voronov@intel.com