Fix handling of composites in sycl-post-link #4530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enchanced our mini-mangler in SpecConstants pass to avoid generating `call bitcast` construct when encountering almost the same functions For example, if you have a call to `%struct.A __spriv_SpecConstantComposite(i32, i32)` and you try to insert a call to `%struct.B __spirv_SpecConstantComposite(i32, i32)` you should be having two calls to two differently mangled functions instead of `call bitcast` construct, which confuses other toolchain components.
kbobrovs
reviewed
Sep 9, 2021
llvm/test/tools/sycl-post-link/spec-constants/multiple-composite-usages.ll
Show resolved
Hide resolved
kbobrovs
approved these changes
Sep 10, 2021
AlexeySachkov
deleted the
private/asachkov/fix-sycl-post-link-arrays-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enchanced our mini-mangler in SpecConstants pass to avoid generating
call bitcastconstruct when encountering almost the same functionsFor example, if you have a call to
%struct.A __spriv_SpecConstantComposite(i32, i32)and you try to insert a call to%struct.B __spirv_SpecConstantComposite(i32, i32)you should be havingtwo calls to two differently mangled functions instead of
call bitcastconstruct, which confuses other toolchain components.
That is achieved by including a mangled return type substring into
the resulting mangling name as
_R{ret-type-mangling}suffix.