[libclc] Change _CLC_DECL to _CLC_DEF for some PTX builtin definitions #4580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
previously approved these changes
Sep 15, 2021
Contributor
|
/summary:run |
Change _CLC_DECL (meant for declaration) to _CLC_DEF. The macro definition of _CLC_DEF adds an `always_inline` attribute needed for optimizations. Signed-off-by: Victor Lomuller <victor@codeplay.com>
Naghasan
force-pushed
the
victor/inline-libclc-call
branch
from
bf79b74 to
40fc4e1
Compare
Author
|
ping @bader :) |
Contributor
|
/summary:run |
bader
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change _CLC_DECL (meant for declaration) to _CLC_DEF.
The macro definition of _CLC_DEF adds an
always_inlineattributeneeded for optimizations.
Signed-off-by: Victor Lomuller victor@codeplay.com