Skip to content

[SYCL][HIP] Fix MemBufferFill for nvidia platform #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2021
Merged

[SYCL][HIP] Fix MemBufferFill for nvidia platform #4629

merged 3 commits into from
Sep 30, 2021

Conversation

AidanBeltonS
Copy link
Contributor

This patch fixes a build error for the HIP backend on nvidia GPUs in the hip_piEnqueueMemBufferFill.
The error is caused by differences in hipDeviceptr_t when targetting an NVIDIA vs AMD gpu. hipDeviceptr_t is typedef'd with CUdeviceptr or void * respectively.

This patch also enables the corresponding MemFill tests with greater than 4 bytes for the HIP backend in unittests/pi/EnqueueMemTest.cpp

@AidanBeltonS AidanBeltonS requested review from a team and smaslov-intel as code owners September 24, 2021 11:50
@bader bader changed the title [SYCL][HIP] fix MemBufferFill for nvidia platform [SYCL][HIP] Fix MemBufferFill for nvidia platform Sep 24, 2021
@bader bader added the hip Issues related to execution on HIP backend. label Sep 24, 2021
@vladimirlaz
Copy link
Contributor

@smaslov-intel could you please have a look?

smaslov-intel
smaslov-intel reviewed Sep 28, 2021
View reviewed changes
@vladimirlaz vladimirlaz merged commit cee76d9 into intel:sycl Sep 30, 2021
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Oct 3, 2021
@alexbatashev
Merge branch 'sycl' into remove_outdated_templates
00da882 
* sycl: (108 commits)
  [SYCL][XPTI] Revisit resource management strategy (intel#4494)
  [SYCL][ESIMD] Fix misprint: ESIMD_L1_FLUASH_RO_DATA -> ESIMD_L1_FLUSH_RO_DATA (intel#4681)
  [SYCL] Make kernel_bundle interop more conformant (intel#4672)
  [SYCL] Submission with kernel parameter ignores set kernel bundle (intel#4667)
  [SYCL] Add support for std::byte to vec class  (intel#4637)
  [BuildBot] Uplift CPU/FPGAEMU RT version for CI Process (intel#4671)
  [SYCL] Fix an error on host when big image is used on opencl:gpu (intel#4668)
  [SYCL] Exclude exported symbols from kernel bundles (intel#4660)
  Revert "[SYCL] Allow overriding plugin libraries (intel#4067)" (intel#4659)
  [SYCL] Handle exceptions on mutually exclusive handler operations (intel#4639)
  [sycl-post-link] Don't split module if function pointer has a user that's not CallInst (intel#4657)
  [SYCL][HIP] Fix MemBufferFill for nvidia platform (intel#4629)
  [SYCL][Doc] Describe DPC++ CUDA install w/ non-standard toolkit loc (intel#4663)
  [SYCL] Fix device code instrumentation (intel#4615)
  Remove myself as a code owner (intel#4653)
  [SYCL] Fix overwriting insert to sub_group_mask (intel#4656)
  [x86][Matrix] Replace packed_a with row_major in matrix testcases (intel#4641)
  [SYCL][Doc] Add device global extension spec (intel#4233)
  [sycl-post-link] Adds property listing exported functions (intel#4626)
  [Driver][SYCL] Do not consider non-archive files for FPGA binary checks (intel#4644)
  ...
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Oct 3, 2021
@alexbatashev
Merge branch 'sycl' into sycl_compile_perf
a4f4c4d 
* sycl: (107 commits)
  [SYCL][XPTI] Revisit resource management strategy (intel#4494)
  [SYCL][ESIMD] Fix misprint: ESIMD_L1_FLUASH_RO_DATA -> ESIMD_L1_FLUSH_RO_DATA (intel#4681)
  [SYCL] Make kernel_bundle interop more conformant (intel#4672)
  [SYCL] Submission with kernel parameter ignores set kernel bundle (intel#4667)
  [SYCL] Add support for std::byte to vec class  (intel#4637)
  [BuildBot] Uplift CPU/FPGAEMU RT version for CI Process (intel#4671)
  [SYCL] Fix an error on host when big image is used on opencl:gpu (intel#4668)
  [SYCL] Exclude exported symbols from kernel bundles (intel#4660)
  Revert "[SYCL] Allow overriding plugin libraries (intel#4067)" (intel#4659)
  [SYCL] Handle exceptions on mutually exclusive handler operations (intel#4639)
  [sycl-post-link] Don't split module if function pointer has a user that's not CallInst (intel#4657)
  [SYCL][HIP] Fix MemBufferFill for nvidia platform (intel#4629)
  [SYCL][Doc] Describe DPC++ CUDA install w/ non-standard toolkit loc (intel#4663)
  [SYCL] Fix device code instrumentation (intel#4615)
  Remove myself as a code owner (intel#4653)
  [SYCL] Fix overwriting insert to sub_group_mask (intel#4656)
  [x86][Matrix] Replace packed_a with row_major in matrix testcases (intel#4641)
  [SYCL][Doc] Add device global extension spec (intel#4233)
  [sycl-post-link] Adds property listing exported functions (intel#4626)
  [Driver][SYCL] Do not consider non-archive files for FPGA binary checks (intel#4644)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bader bader bader approved these changes

+2 more reviewers

@vladimirlaz vladimirlaz vladimirlaz approved these changes

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hip Issues related to execution on HIP backend.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AidanBeltonS @vladimirlaz @bader @smaslov-intel