[NFC] Update sycl-instrumentation.c test to use local sysroot #4798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the local testing SYCL root for finding the libsycl-itt device objects, as not all builds will be creating the objects for the test to properly pass.
hchilama
approved these changes
Oct 21, 2021
AGindinson
approved these changes
Oct 21, 2021
Contributor
AGindinson
left a comment
AGindinson
left a comment
There was a problem hiding this comment.
LGTM, thanks a ton for fixing this one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the local testing SYCL root for finding the libsycl-itt device
objects, as not all builds will be creating the objects for the test
to properly pass.