[SYCL][CUDA][HIP] Update CUDA and HIP libspirv file diagnostic errors #4804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidanBeltonS
requested review from
AGindinson,
elizabethandrews,
hchilama,
mdtoguchi,
premanandrao and
smanna12
as code owners
| "cannot find 'libspirv-nvptx64--nvidiacl.bc'; provide path to libspirv " | ||
| "library via '-fsycl-libspirv-path', or pass '-fno-sycl-libspirv' to build " | ||
| "without linking with libspirv">; | ||
| def err_drv_no_sycl_cuda_libspirv : Error< |
Contributor
There was a problem hiding this comment.
Can you pass file names to the diagnostic and combine the diagnostics?
Contributor
Author
There was a problem hiding this comment.
Yes, that is a good idea. I have combined the diagnostics and passed the target name.
| "libspirv library via '-fsycl-libspirv-path' or pass '-fno-sycl-libspirv' to " | ||
| "build without linking with libspirv. Provide path to " | ||
| "'remangled-l64-signed_char.libspirv-nvptx64--nvidiacl.bc' for Linux " | ||
| "or 'remangled-l32-signed_char.libspirv-nvptx64--nvidiacl.bc' for Windows">; |
Contributor
There was a problem hiding this comment.
Is the 'remangled-... ' part supposed to be a part of this diagnostic?
Contributor
Author
There was a problem hiding this comment.
remangled-... is part of the diagnostic as that is the file name. This is now being passed to the diagnostic and is not hardcoded any longer.
smanna12
reviewed
Oct 22, 2021
steffenlarsen
approved these changes
Oct 26, 2021
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
This is definitely a much better diagnostic message. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates CUDA and HIP's diagnostic errors for libspirv.
Currently, they do not reflect that the libspirv file becomes remangled and is looking for different variants depending upon the OS.
The HIP error also throws the same error as CUDA creating an incorrect message.
This patch resolves these two problems and creates adds HIP tests for the error messages.
This is proposed as a solution to fix #4370