Skip to content

Conversation

@mkinsner
Copy link

Prepare for extension update - fork implemented version so that ready for repo reorganization into "implemented" and "proposed" categories

Signed-off-by: Michael Kinsner michael.kinsner@intel.com

@mkinsner mkinsner requested a review from a team as a code owner November 15, 2021 21:15
@gmlueck
Copy link
Contributor

gmlueck commented Nov 15, 2021

I assume your plan is to modify the original files (e.g. "data_flow_pipes.asciidoc") now that you have created "data_flow_pipes_implemented.asciidoc". However, this will cause problems because the README.md file will point to the version of the file that is not yet implemented ("data_flow_pipes.asciidoc").

I think it would be better to copy these files to something like "data_flow_pipes-rev2-proposed.asciidoc", and then modify the copy. That way the README continue to point to the implemented version.

… for repo reorganization into "implemented" and "proposed" categories

Signed-off-by: Michael Kinsner <michael.kinsner@intel.com>
@mkinsner mkinsner force-pushed the private/mkinsner/split_extension_files branch from 77d492d to 335bac3 Compare November 15, 2021 22:47
@mkinsner
Copy link
Author

I assume your plan is to modify the original files (e.g. "data_flow_pipes.asciidoc") now that you have created "data_flow_pipes_implemented.asciidoc". However, this will cause problems because the README.md file will point to the version of the file that is not yet implemented ("data_flow_pipes.asciidoc").

I think it would be better to copy these files to something like "data_flow_pipes-rev2-proposed.asciidoc", and then modify the copy. That way the README continue to point to the implemented version.

I was trying to prevent someone else needing to rebase, but good point on the links. I changed to reflect your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants