Skip to content

Conversation

@AidanBeltonS
Copy link
Contributor

This PR removes the assert for parallel_for_work_items with one argument. AMD correctly optimises away empty lambda arguments as a result only 1 argument is passed to the parallel_work_itme function. As a result this triggers the assert in fixupPrivateMemoryPFWILambdaCaptures as the number of arguments is equal to 1.

This PR enables tests SpecConstants/2020/kernel_lambda_with_kernel_handler_arg.cpp and SpecConstants/2020/non_native/aot_w_kernel_handler_wo_spec_consts.cpp for the HIP backend.

@bader
Copy link
Contributor

bader commented Dec 1, 2021

/verify with intel/llvm-test-suite#579

@bader
Copy link
Contributor

bader commented Dec 1, 2021

@kbobrovs, several ESIMD tests fail with error: GENX IR generation error: VISA builder API call failed: CisaBuilder->Compile("genxir", &ss, EmitVisa). Please, mark them as "expected to fail" while ESIMD team is working on the fix. This is needed to keep pre-commit results clean from false alarms.

@t4c1, please, apply the same for reduction tests impacted by #5008.

@bader bader merged commit f2db53f into intel:sycl Dec 1, 2021
@t4c1
Copy link
Contributor

t4c1 commented Dec 2, 2021

@bader I don't see any reduction tests failures with #5025. I am not sure if marking some tests with xfail and reverting that after the PR is merged makes sense. The PR is complete, it is just waiting for review.

@bader
Copy link
Contributor

bader commented Dec 2, 2021

Fixing failures is even better. Thanks!

@AidanBeltonS AidanBeltonS deleted the fix-hip-lower-assert branch December 2, 2021 09:57
@kbobrovs
Copy link
Contributor

kbobrovs commented Dec 3, 2021

@bader - will do.

@kbobrovs
Copy link
Contributor

kbobrovs commented Dec 3, 2021

@bader - will do.

I can see these have already been marked. Working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants