-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Diagnose error in L0 for linker options #5268
Conversation
The Level Zero driver does not support any way to pass options that are specific to the online linker, so diagnose an error if the application attempts to pass any. Previously, any such options were silently ignored. Note that the Level Zero driver does support online _compiler_ options, and the plugin correctly handles these.
91bd27c
to
33bc1b2
Compare
This PR is retargeted and rebased now that #5267 is merged. I expect that the following two E2E tests will fail until intel/llvm-test-suite#713 is merged:
|
CI system is able to test if you expectation holds. @gmlueck, you can validate that updated DPC++ runtime passes updated tests by adding following comment |
/verify with intel/llvm-test-suite#713 |
@bader: thanks for this tip, but I must be doing something wrong. I added a comment like this, but testing does not seem to be re-triggered. What did I do wrong? |
This comment doesn't re-trigger Jenkins/Precommit, it triggers a new job Jenkins/llvm-test-suite. I see that SYCL/DeprecatedFeatures/get-options.cpp and SYCL/DeprecatedFeatures/program_link.cpp pass, but SYCL :: Reduction/reduction_usm.cpp failed. Tagging @v-klochkov for awareness. |
/verify with intel/llvm-test-suite#713 |
/verify with intel/llvm-test-suite#713 |
@smaslov-intel : can you review? I have analyzed the failing CI tests, and I think they should not prevent merge: The "Jenkins/Pre-ci-logs" and "Jenkins/Precommit" failures are expected:
Both of these tests were modified in intel/llvm-test-suite#713, and they will pass once that PR is merged. I verified this with the The failure in "SYCL / Default Linux / HIP AMD GPU Test Suite" is unrelated to this PR:
As evidence, you can see that these same three tests also failed in #4937. |
@againull: Thanks for merging! Note that intel/llvm-test-suite#713 also needs to be merged, otherwise the E2E test suite will fail. |
Got it, thank you, merged test as well because 2 PRs were successfully tested together here. |
The Level Zero driver does not support any way to pass options that
are specific to the online linker, so diagnose an error if the
application attempts to pass any. Previously, any such options were
silently ignored.
Note that the Level Zero driver does support online compiler
options, and the plugin correctly handles these.
There is a test case for this PR in intel/llvm-test-suite#713