[Driver][SYCL] Improve archive/listfile representation in the toolchain #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dealing with archives and SYCL device compilations, we recently made adjustments to expect SPIR-V based fat objects. These are unbundled as list files so we can individually convert the SPIR-V to LLVM-IR as needed. The output from the unbundling was being represented as archives instead of the true form of temporary list files. This caused problems when having multiple target output when one of the targets was not spir64 based. Update representation to use the proper file type being created from the unbundling of the archives.
hchilama
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with archives and SYCL device compilations, we recently made
adjustments to expect SPIR-V based fat objects. These are unbundled as
list files so we can individually convert the SPIR-V to LLVM-IR as needed.
The output from the unbundling was being represented as archives instead of
the true form of temporary list files. This caused problems when having
multiple target output when one of the targets was not spir64 based.
Update representation to use the proper file type being created from the
unbundling of the archives.