Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Add mode where only last command in each batch yields a host-visible event #5354

Merged
merged 6 commits into from
Jan 25, 2022

Conversation

smaslov-intel
Copy link
Contributor

@smaslov-intel smaslov-intel commented Jan 20, 2022

E2E test is in intel/llvm-test-suite#765
Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com

…le event

Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
Copy link
Contributor Author

/sumamry:run

Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
Copy link
Contributor Author

/summary:run

@smaslov-intel smaslov-intel marked this pull request as ready for review January 21, 2022 20:50
@smaslov-intel smaslov-intel requested a review from a team as a code owner January 21, 2022 20:50
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel smaslov-intel changed the title [SYCL] mode where only last command in each batch yields a host-visible event [SYCL] add mode where only last command in each batch yields a host-visible event Jan 24, 2022
Copy link
Contributor

@againull againull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS description in the documentation https://github.com/intel/llvm/blob/sycl/sycl/doc/EnvironmentVariables.md

Could you please add a feature test to llvm-test-suite and verify it with this PR.

Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel smaslov-intel requested a review from a team as a code owner January 25, 2022 01:02
Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc ok

@bader bader changed the title [SYCL] add mode where only last command in each batch yields a host-visible event [SYCL] Add mode where only last command in each batch yields a host-visible event Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants