[SYCL][libdevice] Allow iterator debug level mismatch #5669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, users will encounter host link error saying "ITERATOR DEBUG LEVEL MISMATCH" when building programs with /MDd when libsycl-fallback-cassert.obj is involved. In fact, the host obj extracted from libdevice is an empty file and we can use "-D_ALLOW_ITERATOR_DEBUG_LEVEL" to bypass this issue. Signed-off-by: jinge90 <ge.jin@intel.com>
Contributor
Author
|
Hi, @s-kanaev |
s-kanaev
approved these changes
Mar 1, 2022
Contributor
s-kanaev
left a comment
s-kanaev
left a comment
There was a problem hiding this comment.
LGTM
Though, is it possible to have a test for such a behaviour?
Contributor
Author
Contributor
Contributor
|
The testing question was resolved in e-mail thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, users will encounter host link error saying
"ITERATOR DEBUG LEVEL MISMATCH" when building programs
with /MDd when libsycl-fallback-cassert.obj is involved.
In fact, the host obj extracted from libdevice is an
empty file and we can use "-D_ALLOW_ITERATOR_DEBUG_LEVEL"
to bypass this issue.
Signed-off-by: jinge90 ge.jin@intel.com