Skip to content

[SYCL][libclc][CUDA] Add native math extension #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2022

Conversation

pgorlani
Copy link
Contributor

@pgorlani pgorlani commented Mar 7, 2022

This patch extends the native math definitions in order to include builtins out of the current SYCL specification.

In particular, this patch adds a tanh builtin for floats/halfs and a exp2 builtin for halfs which are mapped to instructions introduced for sm_75 and above.

Tests in intel/llvm-test-suite#895

This patch extends the native math definitions in
order to include builtins out of the current SYCL
specification.

In particular, this patch adds a tanh builtin for
floats/halfs and a exp2 builtin for halfs which
are mapped to instructions introduced for sm_75
and above.
@pgorlani pgorlani requested review from a team and bader as code owners March 7, 2022 10:34
@pgorlani pgorlani requested a review from sergey-semenov March 7, 2022 10:34
pgorlani added a commit to pgorlani/llvm-test-suite that referenced this pull request Mar 7, 2022
gmlueck
gmlueck previously approved these changes Mar 7, 2022
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec changes look good to me.

Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE change looks ok to me but I do not have expertise in functionality. I'm only approving to unblock PR. @bader/ someone else more familiar with this, please review.

smanna12
smanna12 previously approved these changes Mar 7, 2022
Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE changes LGTM

@pgorlani pgorlani dismissed stale reviews from smanna12, elizabethandrews, and gmlueck via 07aa4e5 March 9, 2022 11:36
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libclc changes look good to me.

Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE changes LGTM

Copy link
Contributor

@mlychkov mlychkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in llvm inrtinsics definitions LGTM.

@bader
Copy link
Contributor

bader commented Mar 10, 2022

@intel/llvm-reviewers-runtime, ping.

@bader bader merged commit 250c498 into intel:sycl Mar 10, 2022
pgorlani added a commit to pgorlani/llvm-test-suite that referenced this pull request Apr 4, 2022
steffenlarsen pushed a commit to intel/llvm-test-suite that referenced this pull request Jun 23, 2022
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants