-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][libclc][CUDA] Add native math extension #5747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This patch extends the native math definitions in order to include builtins out of the current SYCL specification. In particular, this patch adds a tanh builtin for floats/halfs and a exp2 builtin for halfs which are mapped to instructions introduced for sm_75 and above.
This patch adds tests for intel/llvm#5747
sycl/doc/extensions/experimental/sycl_ext_oneapi_native_math.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_native_math.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_native_math.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_native_math.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_native_math.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE change looks ok to me but I do not have expertise in functionality. I'm only approving to unblock PR. @bader/ someone else more familiar with this, please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE changes LGTM
07aa4e5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libclc changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in llvm inrtinsics definitions LGTM.
@intel/llvm-reviewers-runtime, ping. |
This patch adds tests for intel/llvm#5747
This patch adds tests for intel/llvm#5747
This patch adds tests for intel#5747
This patch extends the native math definitions in order to include builtins out of the current SYCL specification.
In particular, this patch adds a
tanh
builtin for floats/halfs and a exp2 builtin forhalfs
which are mapped to instructions introduced forsm_75
and above.Tests in intel/llvm-test-suite#895