[SYCL] Replace constant address space with global #576
Conversation
| // to generic (and vise-versa). So, global address space is used here instead of | ||
| // constant to avoid incorrect address space casts in the produced device code. | ||
| // "const" qualifier is not used here because multi_ptr interface contains | ||
| // methods which return pure ElementType without qualifiers and adding const |
There was a problem hiding this comment.
I'm not sure I follow this comment.
Can we define type alias as using type = const SYCL_GLOBAL_AS ElementType;?
There was a problem hiding this comment.
Do you think there is something to improve in the specification?
There was a problem hiding this comment.
I'm not sure I follow this comment.
Can we definetypealias asusing type = const SYCL_GLOBAL_AS ElementType;?
No. I didn't add the const qualifier here because multi_ptr interface contains methods and operators which take/return pure ElementType parameter without qualifiers and address spaces. If I use the const qualifier here, I will be forced to add const_casts to these methods to remove const qualifier from underlying pointer type. So adding const qualifier here seems unnecessary.
| // to generic (and vise-versa). So, global address space is used here instead of | ||
| // constant to avoid incorrect address space casts in the produced device code. | ||
| // "const" qualifier is not used here because multi_ptr interface contains | ||
| // methods which return pure ElementType without qualifiers and adding const |
There was a problem hiding this comment.
Do you think there is something to improve in the specification?
Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Fznamznon
force-pushed
the
private/mpodchis/constas
branch
2 times, most recently
from
0e5acba to
814fdd3
Compare
|
Rebased, applied suggestion |
No description provided.