[SYCL] Relax restrictions on non-OpenCL devices during queue creation #5882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Contributor
|
@s-kanaev could you please provide motivation for change? It looks like in general there can be a case when context unrelated to the passed device is returned. Is it expected? |
added 2 commits
April 5, 2022 18:59
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
smaslov-intel
suggested changes
Jun 17, 2022
sergey-semenov
changed the title
bader
reviewed
Jul 11, 2022
Contributor
|
@smaslov-intel @intel/llvm-reviewers-runtime Could you please take a look? |
smaslov-intel
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align device checks during queue construction with SYCL 2020 rev 5:
allow devices that are members of the given context or descendants of
its members. Temporarily keep the old checks for OpenCL, since queue
creation with descendants is not supported there yet.