Skip to content

Conversation

Fznamznon
Copy link
Contributor

@Fznamznon Fznamznon commented Mar 28, 2022

Since device_global variables can be declared in one file and used in
another, it is possible to receive an input with device_global and no
kernels. Make sure that integration header and footer are emitted in this
case.

Since device_global variables can be declared in one file and used in
another, it is possible to receive an input with device_global and no
kernels. Make sure integration header and footer are emitted in this
case.
@Fznamznon Fznamznon requested a review from a team as a code owner March 28, 2022 10:34
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit.

Co-authored-by: premanandrao <premanand.m.rao@intel.com>
Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fznamznon
Copy link
Contributor Author

Thanks for reviews everyone!

@Fznamznon
Copy link
Contributor Author

@intel/llvm-gatekeepers , I believe this one is ready for merge.

The following XPASS on GPU:
Unexpectedly Passed Tests (1):
SYCL :: KernelAndProgram/undefined-symbol.cpp
Is not related to the patch and it seems it is being fixed by https://github.com/intel/llvm-test-suite/pull/958/files .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants