Skip to content

Conversation

steffenlarsen
Copy link
Contributor

According to the compile-time properties specification, the constructor for properties should be constexpr. This was missed in the initial implementation. This commit adds constexpr to the constructor and its constituents.

According to the compile-time properties specification, the constructor
for `properties` should be `constexpr`. This was missed in the initial
implementation. This commit adds `constexpr` to the constructor and
its constituents.

Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen requested a review from a team as a code owner March 30, 2022 14:35
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
vladimirlaz
vladimirlaz previously approved these changes Mar 30, 2022
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
@bader bader merged commit cdf561a into intel:sycl Mar 31, 2022
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Apr 2, 2022
* sycl: (3343 commits)
  [SYCL][L0] Disable round-robin submissions to multiple CCSs (intel#5945)
  [SYCL][CUDA] Don't link pi_cuda against libsycl (intel#5908)
  [CI] Disable -Werror by default (intel#5889)
  [BuildBot] Uplift CPU/FPGAEMU RT version to 2022.13.3.0.16 (intel#5883)
  [SYCL][CUDA][libclc] Add support for atomic fp exchange and compare exchange (intel#5937)
  [SYCL] Fix device code outlining for static local variables (intel#5915)
  [SYCL][NFC] Refactor plugin CMakeLists.txt (intel#5799)
  [SPIR-V][Doc] Add JointMatrixWorkItemLengthINTEL instruction to joint matrix extension (intel#5781)
  [SYCL] Expand device_global map and make initialization order agnostic (intel#5902)
  [SYCL][CUDA] Add IPSCCP pass to O0 by default (intel#5900)
  [ESIMD] Disable ABI changes warnings in host compiler. (intel#5931)
  [SYCL] Make properties constructor constexpr (intel#5928)
  [NFC][SYCL] Fix static analysis warning (intel#5933)
  [CODEOWNERS][NFC] Assign code owners for CI scripts (intel#5873)
  [SYCL] Store the kernel object size in the integration header (intel#5862)
  [SYCL][ESIMD] Change esimd-verifier logic for detecting valid SYCL calls (intel#5914)
  [SYCL][CUDA][DOC] GettingStartedGuide.md to recommend cuda 11.6 (intel#5917)
  [SYCL][L0] Move command list cache usage under mutex (intel#5874)
  [SYCL][FPGA] Prepare future implementation of experimental pipe properties (intel#5886)
  [CI] Roll back intel driver to the latest version (intel#5925)
  ...
@steffenlarsen steffenlarsen deleted the steffen/properties_constexpr_ctor branch December 6, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants