Skip to content

[ESIMD][NFC] Replace deprecated global_buffer with device to avoid wa… #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[ESIMD][NFC] Replace deprecated global_buffer with device to avoid wa… #5946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions sycl/include/sycl/ext/intel/esimd/detail/simd_obj_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,12 +314,12 @@ class simd_obj_impl {
/// argument.
/// @param acc The accessor to read from.
/// @param offset 32-bit offset in bytes of the first element.
template <typename AccessorT, typename Flags = element_aligned_tag,
typename = std::enable_if_t<
detail::is_sycl_accessor_with<
AccessorT, accessor_mode_cap::can_read,
sycl::access::target::global_buffer>::value &&
is_simd_flag_type_v<Flags>>>
template <
typename AccessorT, typename Flags = element_aligned_tag,
typename = std::enable_if_t<
detail::is_sycl_accessor_with<AccessorT, accessor_mode_cap::can_read,
sycl::access::target::device>::value &&
is_simd_flag_type_v<Flags>>>
simd_obj_impl(AccessorT acc, uint32_t offset, Flags = {}) noexcept {
__esimd_dbg_print(simd_obj_impl(AccessorT acc, uint32_t offset, Flags));
copy_from(acc, offset, Flags{});
Expand Down Expand Up @@ -713,7 +713,7 @@ class simd_obj_impl {
int ChunkSize = 32,
typename = std::enable_if_t<is_simd_flag_type_v<Flags>>>
ESIMD_INLINE EnableIfAccessor<AccessorT, accessor_mode_cap::can_read,
sycl::access::target::global_buffer, void>
sycl::access::target::device, void>
copy_from(AccessorT acc, uint32_t offset, Flags = {}) SYCL_ESIMD_FUNCTION;

/// Copy all vector elements of this object into a contiguous block in memory.
Expand All @@ -739,7 +739,7 @@ class simd_obj_impl {
int ChunkSize = 32,
typename = std::enable_if_t<is_simd_flag_type_v<Flags>>>
ESIMD_INLINE EnableIfAccessor<AccessorT, accessor_mode_cap::can_write,
sycl::access::target::global_buffer, void>
sycl::access::target::device, void>
copy_to(AccessorT acc, uint32_t offset, Flags = {}) const SYCL_ESIMD_FUNCTION;

// Unary operations.
Expand Down
4 changes: 2 additions & 2 deletions sycl/include/sycl/ext/intel/esimd/memory.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,7 @@ void simd_obj_impl<T, N, T1, SFINAE>::copy_from(
template <typename T, int N, class T1, class SFINAE>
template <typename AccessorT, typename Flags, int ChunkSize, typename>
ESIMD_INLINE EnableIfAccessor<AccessorT, accessor_mode_cap::can_read,
sycl::access::target::global_buffer, void>
sycl::access::target::device, void>
simd_obj_impl<T, N, T1, SFINAE>::copy_from(AccessorT acc, uint32_t offset,
Flags) SYCL_ESIMD_FUNCTION {
using UT = simd_obj_impl<T, N, T1, SFINAE>::element_type;
Expand Down Expand Up @@ -1255,7 +1255,7 @@ void simd_obj_impl<T, N, T1, SFINAE>::copy_to(
template <typename T, int N, class T1, class SFINAE>
template <typename AccessorT, typename Flags, int ChunkSize, typename>
ESIMD_INLINE EnableIfAccessor<AccessorT, accessor_mode_cap::can_write,
sycl::access::target::global_buffer, void>
sycl::access::target::device, void>
simd_obj_impl<T, N, T1, SFINAE>::copy_to(AccessorT acc, uint32_t offset,
Flags) const SYCL_ESIMD_FUNCTION {
using UT = simd_obj_impl<T, N, T1, SFINAE>::element_type;
Expand Down