[SYCL] Incorrect diagnostic for __spirv calls #6058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethandrews
previously approved these changes
Apr 26, 2022
Contributor
elizabethandrews
left a comment
elizabethandrews
left a comment
There was a problem hiding this comment.
Small nit. LGTM otherwise
smanna12
previously approved these changes
Apr 26, 2022
Contributor
Author
|
Sorry, @smanna12, I had another small piece of unneeded code that I removed too. Please re-review. |
smanna12
reviewed
Apr 26, 2022
elizabethandrews
previously approved these changes
Apr 26, 2022
smanna12
previously approved these changes
Apr 26, 2022
When the reqd_sub_group_size attribute is applied on a sycl kernel, we check that SYCL_EXTERNAL functions called from such kernels also have the same sub_group_size. This need not be enforced on __spirv intrinsics since they are mapped tp the equivalent SPIR-V operations.
premanandrao
dismissed stale reviews from smanna12 and elizabethandrews
via
c143ad5
premanandrao
force-pushed
the
rsgs_spirv
branch
from
8bd1491 to
c143ad5
Compare
Contributor
Author
|
The force push was to fetch #6059 because tests were failing without it. |
smanna12
approved these changes
Apr 27, 2022
elizabethandrews
approved these changes
Apr 27, 2022
Contributor
Author
|
@intel/llvm-gatekeepers, this is ready for a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the reqd_sub_group_size attribute is applied on a
sycl kernel, we check that SYCL_EXTERNAL functions called
from such kernels also have the same sub_group_size. This
need not be enforced on __spirv intrinsics since they are
mapped to the equivalent SPIR-V operations.