Skip to content

Conversation

@kbobrovs
Copy link
Contributor

No description provided.

@kbobrovs kbobrovs requested a review from v-klochkov April 26, 2022 22:55
@kbobrovs kbobrovs requested a review from a team as a code owner April 26, 2022 22:55
Copy link
Contributor

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good.
IMO, there are few more places where changes are needed, e.g. the line 107:
sycl::ext::intel::experimental::esimd::block_store
-->
sycl::ext::intel::esimd::block_store

@kbobrovs
Copy link
Contributor Author

Failures are unrelated:
Linking CXX shared library lib/libpi_level_zero.so
FAILED: lib/libpi_level_zero.so
...
pi_level_zero.cpp:(.text.piextProgramGetNativeHandle+0x54): undefined reference to `pthread_rwlock_rdlock

Since this patch touches only docs and doxygen task is OK, I'm merging.

@kbobrovs kbobrovs merged commit 9677b9f into sycl Apr 27, 2022
@kbobrovs
Copy link
Contributor Author

@smaslov-intel, please be aware of the libpi_level_zero.so build failure

@smaslov-intel
Copy link
Contributor

@smaslov-intel, please be aware of the libpi_level_zero.so build failure

Thanks. This is already fixed in #6059

@kbobrovs
Copy link
Contributor Author

The changes are good. IMO, there are few more places where changes are needed, e.g. the line 107: sycl::ext::intel::experimental::esimd::block_store --> sycl::ext::intel::esimd::block_store

Did not notice this message. You are right, will fix too.

@kbobrovs kbobrovs deleted the kbobrovs-esimd-doc-fix branch April 27, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants