Skip to content

[SYCL][CUDA] fix warnings in async barrier #6165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvchupin merged 3 commits into from
May 19, 2022
Merged

[SYCL][CUDA] fix warnings in async barrier #6165

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
511f1ef
fix warnings in async barrier
t4c1 May 18, 2022
18304e3
Address review comment
againull May 18, 2022
281de2a
Remove unnecessary (void)state
againull May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sycl/include/sycl/ext/oneapi/experimental/cuda/barrier.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ class barrier {
#ifdef __SYCL_DEVICE_ONLY__
__clc_BarrierInitialize(&state, expected_count);
#else
(void)state;
(void)expected_count;
throw runtime_error("Barrier is not supported on host device.",
PI_INVALID_DEVICE);
#endif
Expand Down Expand Up @@ -68,6 +70,7 @@ class barrier {
#ifdef __SYCL_DEVICE_ONLY__
return __clc_BarrierArriveNoComplete(&state, count);
#else
(void)count;
throw runtime_error("Barrier is not supported on host device.",
PI_INVALID_DEVICE);
#endif
Expand All @@ -77,6 +80,7 @@ class barrier {
#ifdef __SYCL_DEVICE_ONLY__
return __clc_BarrierArriveAndDropNoComplete(&state, count);
#else
(void)count;
throw runtime_error("Barrier is not supported on host device.",
PI_INVALID_DEVICE);
#endif
Expand Down Expand Up @@ -104,6 +108,7 @@ class barrier {
#ifdef __SYCL_DEVICE_ONLY__
__clc_BarrierWait(&state, arrival);
#else
(void)arrival;
throw runtime_error("Barrier is not supported on host device.",
PI_INVALID_DEVICE);
#endif
Expand All @@ -113,6 +118,7 @@ class barrier {
#ifdef __SYCL_DEVICE_ONLY__
return __clc_BarrierTestWait(&state, arrival);
#else
(void)arrival;
throw runtime_error("Barrier is not supported on host device.",
PI_INVALID_DEVICE);
#endif
Expand Down