-
Notifications
You must be signed in to change notification settings - Fork 809
[SYCL] Add new metadata kernel_arg_exclusive_ptr #6190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kernel_arg_exclusive_ptr metadata guarantees that the kernel pointer argument, or pointers that derive from it, will not be dereferenced outside current invocation of the kernel. At the moment, this guarantee is met by the base pointer of an accessor. Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
premanandrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with the general SYCL changes. I would like @kbobrovs review the ESIMD changes.
Thanks for taking a look. Just an FYI there are no ESIMD changes in this patch at the moment. We still generate the same metadata. |
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
|
@intel/llvm-gatekeepers I think this patch is ready for review and merge. There is a pending question of whether we can replace ESIMD metadata |
kernel_arg_exclusive_ptr metadata guarantees that the kernel
pointer argument, or pointers that derive from it, will not be
dereferenced outside current invocation of the kernel.
At the moment, this guarantee is met by the base pointer of an
accessor.
Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com