Skip to content

Conversation

@elizabethandrews
Copy link
Contributor

kernel_arg_exclusive_ptr metadata guarantees that the kernel
pointer argument, or pointers that derive from it, will not be
dereferenced outside current invocation of the kernel.

At the moment, this guarantee is met by the base pointer of an
accessor.

Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com

kernel_arg_exclusive_ptr metadata guarantees that the kernel
pointer argument, or pointers that derive from it, will not be
dereferenced outside current invocation of the kernel.

At the moment, this guarantee is met by the base pointer of an
accessor.

Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
@elizabethandrews elizabethandrews requested a review from a team as a code owner May 25, 2022 16:54
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with the general SYCL changes. I would like @kbobrovs review the ESIMD changes.

@elizabethandrews
Copy link
Contributor Author

I am okay with the general SYCL changes. I would like @kbobrovs review the ESIMD changes.

Thanks for taking a look. Just an FYI there are no ESIMD changes in this patch at the moment. We still generate the same metadata.

Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
@elizabethandrews
Copy link
Contributor Author

@intel/llvm-gatekeepers I think this patch is ready for review and merge. There is a pending question of whether we can replace ESIMD metadata kernel_arg_accessor_ptr to use the new metadata kernel_arg_exclusive_ptr since both metadata seem to be maintaining list of boolean values for kernel arguments (to mark base pointer of accessor). I think that discussion is orthogonal to this patch. If ESIMD metadata can be replaced, I will do it in a follow-up patch. Else I will remove the FIXME in a follow-up patch once the discussion is complete

@pvchupin pvchupin merged commit e03c4ed into intel:sycl Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants