Skip to content

Conversation

@pvchupin
Copy link
Contributor

@pvchupin pvchupin commented May 26, 2022

  • Update reusable workflow with corresponding config
  • Add cuda llvm-test-suite run to pre-commit on Linux
  • Fix option typo [NFC]

Failing tests disabled at: intel/llvm-test-suite#1052
Issue: #6285

* Updating reusable workflow with corresponding config
* Fix option typo
@pvchupin pvchupin marked this pull request as ready for review June 8, 2022 20:54
@pvchupin pvchupin requested a review from a team as a code owner June 8, 2022 20:55
@cperkinsintel
Copy link
Contributor

Getting lots of failures on the CUDA run of the tests. Are there updated headers we should be using?

@pvchupin
Copy link
Contributor Author

pvchupin commented Jun 9, 2022

@steffenlarsen has a fix in progress for a few of these problems. I'm going to mark the rest with UNSUPPORTED:cuda and open a separate issue to address these.
Tagging @AerialMantis

@steffenlarsen
Copy link
Contributor

Couple of patches up for failing tests:

Additionally, the following patches should fix some problems seen on Windows testing:

In local testing on Windows I still see failure in the following tests after the above changes are applied:

  SYCL :: Sampler/unnormalized-clamp-nearest.cpp
  SYCL :: Sampler/unnormalized-clampedge-nearest.cpp
  SYCL :: Sampler/unnormalized-none-nearest.cpp

If they continue to fail after the patches have been merged I suggest we disable these and file an issue.

@pvchupin
Copy link
Contributor Author

pvchupin commented Jun 9, 2022

Ok, after merging bunch of changes above and retesting I see the same 3 fails as @steffenlarsen mentioned. I'm going to disable these and open an issue.

@pvchupin
Copy link
Contributor Author

pvchupin commented Jun 9, 2022

/verify with intel/llvm-test-suite#1052

@pvchupin
Copy link
Contributor Author

pvchupin commented Jun 9, 2022

I realized "/verify with" is useless here because it doesn't run CUDA testing. I actually need to merge that change first and rerun again.

@pvchupin pvchupin merged commit c7e5711 into intel:sycl Jun 10, 2022
@pvchupin pvchupin deleted the cuda-linux branch June 10, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants